Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: Replaced by IAttachmentHasId #7629

Merged
merged 1 commit into from
May 8, 2023

Conversation

reiji-h
Copy link
Contributor

@reiji-h reiji-h commented May 8, 2023

https://redmine.weseek.co.jp/issues/120922

概要

IAttachment & HasObjectId が使用されている箇所を IAttachmentHasId に置き換える。

@reiji-h reiji-h changed the title fix: replaced by IAttachmentHasId imprv: replaced by IAttachmentHasId May 8, 2023
@reiji-h reiji-h self-assigned this May 8, 2023
@reiji-h reiji-h requested a review from jam411 May 8, 2023 05:58
@reiji-h reiji-h temporarily deployed to VRT May 8, 2023 06:04 — with GitHub Actions Inactive
@reg-suit
Copy link

reg-suit bot commented May 8, 2023

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴
⚪⚪
⚫⚫
🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@jam411
Copy link
Contributor

jam411 commented May 8, 2023

細かいですが、PRタイトルを imprv: Replaced by IAttachmentHasId にしておいてください。
参考: https://growi.weseek.co.jp/5aa27fa1a57dfb002f14a5ac#mdcont-master-%E3%81%AB%E5%90%91%E3%81%91%E3%81%9F-pr-%E3%81%AE%E3%82%BF%E3%82%A4%E3%83%88%E3%83%AB

@reiji-h reiji-h changed the title imprv: replaced by IAttachmentHasId imprv: Replaced by IAttachmentHasId May 8, 2023
@yuki-takei yuki-takei merged commit 25e3d49 into master May 8, 2023
@yuki-takei yuki-takei deleted the fix/120922-121620-replace-by-IAttachmentHasId branch May 8, 2023 10:12
@github-actions github-actions bot mentioned this pull request May 8, 2023
@jam411 jam411 removed the type/bug label May 8, 2023
@yuki-takei yuki-takei changed the title imprv: Replaced by IAttachmentHasId support: Replaced by IAttachmentHasId May 15, 2023
@yuki-takei yuki-takei mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants