imprv: Enable marp from adminsetting #7939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiji-h
changed the title
jam411
suggested changes
Aug 2, 2023
jam411
approved these changes
Aug 4, 2023
yuki-takei
requested changes
Aug 4, 2023
| "select_search_scope_children_as_default_desc": "OFFの場合、検索範囲のデフォルト設定は「全てのページ」になります。" | ||
| "select_search_scope_children_as_default_desc": "OFFの場合、検索範囲のデフォルト設定は「全てのページ」になります。", | ||
| "enable_marp": "Marp を有効化する", | ||
| "enable_marp_desc": "OFFの場合、Marp は使用できません。", |
There was a problem hiding this comment.
プレゼンテーション表示に Marp を利用できるようになります。
に変更して。
更に、XSS に対して脆弱になり得るということを追記してください。
| </p> | ||
| </CustomizeFunctionOption> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Functions の中ごちゃごちゃしてきたから、「プレゼンテーション」っていうサブセクションがほしいな
後続ストーリーにして meiri-k にアサインしてください。
reiji-h
changed the base branch from
feat/115673-marp
to
imprv/115672-presentation-preview
reiji-h
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Task
Screenshot