-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imprv: Enable Marp in presentation mode #7956
Merged
yuki-takei
merged 10 commits into
imprv/115672-presentation-preview
from
imprv/115673-126792-use-marp-in-presentation
Aug 21, 2023
Merged
imprv: Enable Marp in presentation mode #7956
yuki-takei
merged 10 commits into
imprv/115672-presentation-preview
from
imprv/115673-126792-use-marp-in-presentation
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v/115673-126792-use-marp-in-presentation
…v/115673-126792-use-marp-in-presentation
Base automatically changed from
imprv/115673-115675-enable-from-adminsetting
to
imprv/115672-presentation-preview
August 7, 2023 03:46
jam411
reviewed
Aug 8, 2023
jam411
approved these changes
Aug 10, 2023
yuki-takei
requested changes
Aug 13, 2023
} | ||
}) | ||
.process(children as string); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- この unified を使って frontmatter を解析する部分をカスタムフックとして別モジュール(ファイル)に分離させてください
- frontmatter 解析は useEffect の外でいいのではないか?(未検証)
- そうであれば setMarp を用意する useState も不要だと思う
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- parse-slide-frontmatter.ts として分離しました。
- useEffect の外でも問題なかったので、useState と合わせて使用しないように修正しました。
…6792-use-marp-in-presentation
…6792-use-marp-in-presentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Task
備考