feat: Implementation of autocompletion function for emoji input #8137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
reviewed
Oct 30, 2023
...s/editor/src/services/codemirror-editor/use-emoji-autocompletion/use-emoji-autocompletion.ts
Outdated
Show resolved
Hide resolved
|
reg-suit detected visual differences. Check this report, and review them. ⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪ What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
yuki-takei
requested changes
Oct 31, 2023
packages/editor/src/services/codemirror-editor/use-codemirror-editor/use-codemirror-editor.ts
Outdated
Show resolved
Hide resolved
| return { | ||
| from: emojiBefore ? nodeBefore.from + emojiBefore.index : context.pos, | ||
| options: emojiOptions, | ||
| validFor: /^:\w{2,}$/, |
There was a problem hiding this comment.
この正規表現はモジュール変数に入れておく(上でも使っているので)
また、2文字以上入力した時に働くという挙動の説明をコード内コメントとして入れておいてください
WNomunomu
changed the title
Closed
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
タスク
https://redmine.weseek.co.jp/issues/131552
https://redmine.weseek.co.jp/issues/131550
概要
コロンの後にアルファベットを2文字以上入力すると絵文字の予測変換が出るようにしました。
また、予測変換の絵文字を選択すると絵文字が入力されるようになりました。
(下の画像参考)