feat: Uniform behavior when creating pages from create new page button #8297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
これは不正確では？
これは良いと思う。 |
yuki-takei
requested changes
Dec 8, 2023
jam411
commented
Dec 15, 2023
apps/app/src/pages/utils/commons.ts
Outdated
Comment on lines
168
to
170
| const { mutate } = useSWRxCurrentPage(); | ||
| // clear 'currentPage' cache for page create button | ||
| mutate(undefined, { revalidate: false }); |
There was a problem hiding this comment.
useInitSidebarConfig でキャッシュをクリアするようにしました。
- useCurrentPagePath の中で読んでいる useSWRxCurrentPage のキャッシュを消す必要がありました。
- mutate を使っているのは https://swr.vercel.app/docs/advanced/cache#modify-the-cache-data を参照
There was a problem hiding this comment.
ここに書くとこの hook を使っているコンポーネントが re-rendering される度に mutate が走るので、ここでやるのは違う
yuki-takei
requested changes
Dec 15, 2023
apps/app/src/pages/utils/commons.ts
Outdated
Comment on lines
168
to
170
| const { mutate } = useSWRxCurrentPage(); | ||
| // clear 'currentPage' cache for page create button | ||
| mutate(undefined, { revalidate: false }); |
There was a problem hiding this comment.
ここに書くとこの hook を使っているコンポーネントが re-rendering される度に mutate が走るので、ここでやるのは違う
…11-update-create-page-method
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
Closed
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://redmine.weseek.co.jp/issues/135811
やったこと
特に見てほしい仕様
/trash/meなどでページ作成ボタンを投下すると、page データのキャッシュがあればそのページ配下へページが作成されます。useSWRxCurrentPageから取得しています。なので、/trash/me/tagsでは useSWRxCurrentPage から取得できる page データが swr キャッシュにより、ルートページ配下ではなく、その前に取得していた page 情報になる場合がある。その他の仕様まとめ（どのページ配下にページを作る/遷移するのか）
/{path}/{additional_path}パスを作成しページを作る/{path}/{additional_path}がすでに存在していたら:/{path}/{additional_path}を作成/{path}/{additional_path}が作成できないパス（path が Not Found Page や Not Creatable Page なども）であるか、もしくは path を受け取れないときは、ルートページ配下へ/{additional_path}を作成もしくへ編集画面へ遷移する