Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: behaviour when pressing enter after numerical input (ex: 2.3.4.) #8754

Conversation

WNomunomu
Copy link
Contributor

タスク

https://redmine.weseek.co.jp/issues/144347

概要

  • 2.3.4. などの数値入力後にenterを押下すると、次の行に 2. が自動で挿入されてしまう問題を解決しました。

変更点

  • 正規表現を新しいものに置き換えました。
  • 旧式の正規表現では 2.3.4. もマークダウンとして認識していましたが、新しいものでは、2.3.4. は普通のテキストとして認識されます。

セルフチェック

  • コンフリクト解消したか
  • 余計なコードは残っていないか
  • 適切にメモ化したか
  • 責務の問題はクリアしているか
  • CIは通っているか
  • PRの内容は適切にかけているか

Sorry, something went wrong.

This reverts commit ba5d854.
Copy link

reg-suit bot commented Apr 24, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴


🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei merged commit 4415ce7 into master Apr 25, 2024
20 of 24 checks passed
@yuki-takei yuki-takei deleted the imprv/141097-144347-behaviour-when-pressing-enter-after-numerical-input branch April 25, 2024 08:57
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants