Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Behaviour of table operation by enter key in editor #8756

Merged

Conversation

WNomunomu
Copy link
Contributor

@WNomunomu WNomunomu commented Apr 24, 2024

タスク

https://redmine.weseek.co.jp/issues/144502

概要

  • editor内でのテーブル操作の挙動を修正しました。

変更点

  • removeRow関数内で、テーブルの行を削除した後に、カーソルが遷移する場所を決定するようにしました。
  • これによって、副作用を適切に扱うことができるようになりました。

セルフチェック

  • コンフリクト解消したか
  • 余計なコードは残っていないか
  • 適切にメモ化したか
  • 責務の問題はクリアしているか
  • CIは通っているか
  • PRの内容は適切にかけているか

Copy link

reg-suit bot commented Apr 24, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei changed the title fix: behaviour of table operation in editor fix: Behaviour of table operation by enter key in editor Apr 25, 2024
@yuki-takei yuki-takei merged commit 5351db1 into master Apr 25, 2024
24 of 27 checks passed
@yuki-takei yuki-takei deleted the fix/141686-144502-behavior-of-table-operation-in-editor branch April 25, 2024 11:47
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants