Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: Editor mobile appearance #8760

Merged
merged 13 commits into from
Apr 25, 2024

Conversation

satof3
Copy link
Contributor

@satof3 satof3 commented Apr 25, 2024

Task

Summary

  • 検索ボタンを Edit モードのときに非表示にした
  • md以下の各サイズでページ名とページパスの表示可能幅を調整
  • エディタのモバイル時の表示を改善
    • lg のときに左側ハンバーガーメニューとのページタイトルのレイアウトを調整
    • lg 以下で 通知・お気に入り・ブックマーク・足跡 アイコンを非表示にした
    • md 以下でサイドバーをDrawerモードで表示させるハンバーガーメニューボタンを表示
    • sm 以下で同時多人数編集のアイコンを左上に配置されるようにした
    • sm 以下でタグボタンの文字が消え、アイコンのみにした

Screenshot

  • image
  • image
  • image

やり残し 後続タスク

Copy link

reg-suit bot commented Apr 25, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴
⚪⚪⚪
⚫⚫
🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei merged commit 616a02c into master Apr 25, 2024
21 of 24 checks passed
@yuki-takei yuki-takei deleted the support/144785-editor-mobile-appearance branch April 25, 2024 13:01
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants