Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: An error occurred during user activation via email #8767

Merged
merged 5 commits into from
May 1, 2024

Conversation

maeshinshin
Copy link
Contributor

@maeshinshin maeshinshin commented Apr 26, 2024

Task

#144137: ユーザー登録時のメール認証」を有効時に「Activation」画面で「作成」ボタンを押下しても反応しない件の修正
#144368 実装

Demo

demo-ezgif.com-crop-video.mp4

apps/app/src/pages/user-activation.page.tsx Outdated Show resolved Hide resolved
apps/app/src/pages/user-activation.page.tsx Outdated Show resolved Hide resolved
Copy link

reg-suit bot commented May 1, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei
Copy link
Member

fix #8510

@yuki-takei yuki-takei merged commit d638a0d into master May 1, 2024
27 of 30 checks passed
@yuki-takei yuki-takei deleted the fix/144137-144368-email-user-activation-error branch May 1, 2024 20:55
@github-actions github-actions bot mentioned this pull request May 1, 2024
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants