Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imprv: Security settings screen redesign #9137
base: master
Are you sure you want to change the base?
imprv: Security settings screen redesign #9137
Changes from 11 commits
fe638af
cd7c084
d3cb7b1
c8cf39f
ebf19b9
4dc9e0f
a111d8a
2539514
7554980
1cd37f6
b09b1c3
41d2417
80738ec
e3308cf
5d7b7d2
51846cc
27f0456
9ca6bbe
d0a234d
b110455
f12384b
3a52bc7
830e47d
4454263
4d77d26
e6097e9
7de782a
a7379c7
a8b9f65
cfba07b
559bfb9
329ff06
815a6cf
e6c59e8
97d8026
0a1d065
2f3e64a
cee387b
23ffa59
9457238
cd3a35d
4ba7c10
3deee53
abed3e6
71d538f
5300f52
d5f5c7e
c139953
839cd92
433fee7
fd16e22
4b4b83d
32f75ff
d8fcbc7
2063190
3b8663d
e9709dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここにメソッドを渡しているのはなぜ? switchIsShowRestrictedByOwner というメソッド自体不要なら AdminGeneralSecurityContainer から削除してください。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switchIsShowRestrictedByOwner を使わないなら削除してください