Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA take2 #97

Merged
merged 4 commits into from
Mar 17, 2021
Merged

GHA take2 #97

merged 4 commits into from
Mar 17, 2021

Conversation

ocefpaf
Copy link
Collaborator

@ocefpaf ocefpaf commented Mar 11, 2021

This moves the package publication to GitHub Actions. But it is not ready to be merged yet!

We need to add a PyPI token as a GH secret and I do not have the permissions to do so in this repo.
@wesleybowman can you add the token or give some of us permission to do it? We'll need it again when I move the documentation builds to GH Actions.

@ocefpaf ocefpaf marked this pull request as draft March 11, 2021 13:14
@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Mar 11, 2021

I converted this to a draft until we can set the tokens up.

@wesleybowman
Copy link
Owner

@ocefpaf I've added PYPI_PASSWORD to the Repo's secrets

Sorry for the delay, been a busy week.

@ocefpaf ocefpaf marked this pull request as ready for review March 16, 2021 18:14
@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Mar 16, 2021

@ocefpaf I've added PYPI_PASSWORD to the Repo's secrets

Awesome! Thanks!!

Sorry for the delay, been a busy week.

Don't worry. There is no hurry at all. Just want to tidy things up a bit for future proof our CI.

@ocefpaf ocefpaf requested a review from efiring March 16, 2021 18:16
Copy link
Collaborator

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible--I think I see roughly what is going on. Let's try it. Merge when ready.

@ocefpaf ocefpaf merged commit 8c97f5e into wesleybowman:master Mar 17, 2021
@ocefpaf ocefpaf deleted the GHA_take2 branch March 17, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants