fix(tabs): angular-ui#2883 select gets called twice

wesleycho · Aug 18, 2015 · 3a4435d · 3a4435d
1 parent 790d6b9
commit 3a4435d
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/tabs/tabs.js b/src/tabs/tabs.js
@@ -18,10 +18,15 @@ angular.module('ui.bootstrap.tabs', [])
       if (tab.active && tab !== selectedTab) {
         tab.active = false;
         tab.onDeselect();
+        selectedTab.selectCalled = false;
       }
     });
     selectedTab.active = true;
-    selectedTab.onSelect();
+    // only call select if it has not already been called
+    if (!selectedTab.selectCalled) {
+      selectedTab.onSelect();
+      selectedTab.selectCalled = true;
+    }
   };
 
   ctrl.addTab = function addTab(tab) {