Skip to content

Commit

Permalink
PARQUET-513: Fail build if valgrind finds error during ctest, fix a c…
Browse files Browse the repository at this point in the history
…ore dump

Also adds an option to use ccache with a custom gcc toolchain.

Fixes an improper memory access stemming from a unit test that had a wrong parameter.

Author: Wes McKinney <wes@cloudera.com>

Closes apache#42 from wesm/PARQUET-513 and squashes the following commits:

43df9e7 [Wes McKinney] Fix core dump from unit test bug
b46c617 [Wes McKinney] Fail build if valgrind finds error during ctest

Change-Id: I4e04fee7db2ed7a0af21ab25b9d7566314d07ac4
  • Loading branch information
wesm authored and julienledem committed Feb 9, 2016
1 parent 589ada7 commit c5db134
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/src/parquet/schema/schema-converter-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ TEST_F(TestSchemaConverter, NotEnoughChildren) {
SchemaElement elt;
std::vector<SchemaElement> elements;
elements.push_back(NewGroup(name_, FieldRepetitionType::REPEATED, 2));
ASSERT_THROW(Convert(&elements[0], 2), ParquetException);
ASSERT_THROW(Convert(&elements[0], 1), ParquetException);
}

// ----------------------------------------------------------------------
Expand Down

0 comments on commit c5db134

Please sign in to comment.