Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLI-0046] Build status of master is failing #46

Closed
thewillyhuman opened this issue Apr 3, 2020 · 11 comments · Fixed by #47 or #48
Closed

[SLI-0046] Build status of master is failing #46

thewillyhuman opened this issue Apr 3, 2020 · 11 comments · Fixed by #47 or #48

Comments

@thewillyhuman
Copy link
Member

Locally all tests pass:
imagen
But on travis they fail...

@thewillyhuman
Copy link
Member Author

Now travis claims that the library scoverage is not available: https://travis-ci.org/github/weso/shex-lite/jobs/670493746#L391

@thewillyhuman
Copy link
Member Author

Now the travis error is The compiler bridge sources org.scala-sbt:compiler-bridge_2.13:1.1.1:compile could not be retrieved. From here: https://travis-ci.org/github/weso/shex-lite/jobs/670496045#L398

@thewillyhuman
Copy link
Member Author

Okey so here I found an issue with the same error but the solution they implemented did not work for me...

Help @alejgh @labra please...

@alejgh
Copy link
Member

alejgh commented Apr 3, 2020

Okay, I have been doing some tests and I cannot currently build the project even locally since you made the change to the sbt version in project/build.properties.

I think that sbt 1.1.1 is not compatible with Scala 2.13.1?

If I restore the sbt version to the original one (1.3.7) I get one fail from the test suite:

[info] IdentificationWalkerTest:
[info] - Check that a base redefinition is detected by the identification walker *** FAILED ***
[info]   compiler.semantic.MemoryErrorHandler.hasErrors was true (IdentificationWalkerTest.scala:55)
[info] - Check that a base declaration is detected by the identification walker
[info] PrefixDefinitionSyntaxTest:
[info] - A prefix with a bad iri is not accepted
[info] - A good formed prefix is accepted
[info] Run completed in 549 milliseconds.
[info] Total number of tests run: 20
[info] Suites: completed 3, aborted 0
[info] Tests: succeeded 19, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***
[error] Failed tests:
[error] 	compiler.IdentificationWalkerTest
[error] (Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 18 s, completed Apr 3, 2020, 1:21:52 PM

I think we had this error in travis earlier in the morning.

Regarding the problems with travis and scoverage, there is this issue available scoverage/sbt-scoverage#295

@alejgh
Copy link
Member

alejgh commented Apr 3, 2020

@labra has also faced this problem: weso/utils#3

@thewillyhuman
Copy link
Member Author

Yeah sbt version change was just for testing, you can change it to usual on e(1.3.7) with no problem. Will try to fix it my self. That error in the tests is also strange as in intellij report all of them pass...

@alejgh
Copy link
Member

alejgh commented Apr 3, 2020

Should we revert the Scala version to 2.13.0 to see if it works?

@thewillyhuman
Copy link
Member Author

If you could try it meanwhile I work on the travis configuration of the hercules-ontology repo would be awesome. Otherwise will try it myself later.

@alejgh
Copy link
Member

alejgh commented Apr 3, 2020

Yeah sbt version change was just for testing, you can change it to usual on e(1.3.7) with no problem. Will try to fix it my self. That error in the tests is also strange as in intellij report all of them pass...

I'm running the tests locally from the command line, maybe Intellij does something else under the hood 🤔

@alejgh
Copy link
Member

alejgh commented Apr 3, 2020

If you could try it meanwhile I work on the travis configuration of the hercules-ontology repo would be awesome. Otherwise will try it myself later.

Yes, I will start a pull request

@thewillyhuman
Copy link
Member Author

Yeah sbt version change was just for testing, you can change it to usual on e(1.3.7) with no problem. Will try to fix it my self. That error in the tests is also strange as in intellij report all of them pass...

I'm running the tests locally from the command line, maybe Intellij does something else under the hood 🤔

Okay at the end of the day if what fails is the test I'm not so worried. At least they are being executed.

@thewillyhuman thewillyhuman linked a pull request Apr 3, 2020 that will close this issue
thewillyhuman added a commit that referenced this issue Apr 3, 2020
[WIP] Fix build errors of issue #46
@thewillyhuman thewillyhuman linked a pull request Apr 3, 2020 that will close this issue
@thewillyhuman thewillyhuman changed the title Build status of master is failing [SLI-0046] Build status of master is failing Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment