Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Xerces #147

Closed
berezovskyi opened this issue Oct 16, 2021 · 2 comments · Fixed by #148
Closed

Remove dependency on Xerces #147

berezovskyi opened this issue Oct 16, 2021 · 2 comments · Fixed by #148

Comments

@berezovskyi
Copy link
Contributor

Hello,

Dependency on Xerces in Shaclex prevents us from compiling under JDK 17:

[INFO] Running org.eclipse.lyo.validation.ShaclMaxExclusiveValidationTest
java.lang.IllegalAccessError: class es.weso.utils.RegEx (in unnamed module @0x1e7ba8d9) cannot access class com.sun.org.apache.xerces.internal.impl.xpath.regex.RegularExpression (in module java.xml) because module java.xml does not export com.sun.org.apache.xerces.internal.impl.xpath.regex to unnamed module @0x1e7ba8d9
	at es.weso.utils.RegEx.matches(RegexUtils.scala:17)
    ...

While not a blocker (we intend to stay on JDK 8 as long as possible for our users), we'd like to resolve build errors in order not to accrue tech debt. Xerces should not be included in the new projects as JAXB has almost everything you need. Moreover, I noticed you only use it for regexp processing. Is there a reason java.util.regex.Pattern cannot be used?

Best regards,
Andrew

berezovskyi added a commit to berezovskyi/utils that referenced this issue Oct 16, 2021
Closes weso#147

Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@thewillyhuman
Copy link
Member

Hi @berezovskyi, thank you very much for your contribution. It is well motivated and the code provided solves it. As soon as we can check it thoroughly, we will inform you.

@thewillyhuman
Copy link
Member

Hi @berezovskyi! We have deployed release v0.1.100 with the latest changes. Please note that it usually takes a while (30mins - 1h) to be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants