Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch2 delete target db pattern #599

Merged
merged 13 commits into from
Dec 11, 2024
Merged

Branch2 delete target db pattern #599

merged 13 commits into from
Dec 11, 2024

Conversation

newborn22
Copy link
Collaborator

Related Issue(s) & Descriptions

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

earayu
earayu reviewed Dec 11, 2024
View reviewed changes
go/vt/vtgate/branch/target_mysql_service.go Outdated Show resolved Hide resolved
go/vt/vtgate/branch/target_mysql_service.go Outdated Show resolved Hide resolved
go/vt/vtgate/engine/branch_primitive.go Show resolved Hide resolved
This was linked to issues Dec 11, 2024
[Enhancement Request] Rename 'branch clean_up' command to 'branch delete' #597
Closed
[Bug Report] Branch Show Command Displays Garbled Characters #598
Closed
earayu
earayu approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@earayu earayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earayu earayu merged commit 8a7fdb1 into main Dec 11, 2024
22 checks passed
@earayu earayu deleted the branch2_delete_target_db_pattern branch December 11, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earayu earayu earayu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@newborn22 @earayu