Modified arrow::internal::GroupBy to use an exec plan directly instea…

…d of emulating one apacheGH-14866: converted GroupBy into a proper convenience function, accepting arrays and returning table, with unit tests
westonpace · Jan 25, 2023 · b5bfe85 · b5bfe85
1 parent f3637ac
commit b5bfe85
Show file tree

Hide file tree

Showing 15 changed files with 1,241 additions and 1,219 deletions.
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
@@ -385,7 +385,7 @@ if(ARROW_COMPUTE)
        compute/api_vector.cc
        compute/cast.cc
        compute/exec.cc
-       compute/exec/aggregate.cc
+       compute/exec/groupby.cc
        compute/exec/accumulation_queue.cc
        compute/exec/aggregate_node.cc
        compute/exec/asof_join_node.cc

diff --git a/cpp/src/arrow/compute/api.h b/cpp/src/arrow/compute/api.h
@@ -58,3 +58,4 @@
 
 #include "arrow/compute/exec.h"            // IWYU pragma: export
 #include "arrow/compute/exec/exec_plan.h"  // IWYU pragma: export
+#include "arrow/compute/exec/groupby.h"    // IWYU pragma: export
diff --git a/cpp/src/arrow/compute/exec/CMakeLists.txt b/cpp/src/arrow/compute/exec/CMakeLists.txt
@@ -45,6 +45,7 @@ add_arrow_compute_test(asof_join_node_test
                        test_nodes.cc)
 add_arrow_compute_test(tpch_node_test PREFIX "arrow-compute")
 add_arrow_compute_test(union_node_test PREFIX "arrow-compute")
+add_arrow_compute_test(groupby_test PREFIX "arrow-compute")
 add_arrow_compute_test(util_test
                        PREFIX
                        "arrow-compute"

diff --git a/cpp/src/arrow/compute/exec/aggregate.cc b/cpp/src/arrow/compute/exec/aggregate.cc
diff --git a/cpp/src/arrow/compute/exec/aggregate.h b/cpp/src/arrow/compute/exec/aggregate.h
Original file line number	Diff line number	Diff line change
Expand Up		@@ -58,3 +58,4 @@

		#include "arrow/compute/exec.h" // IWYU pragma: export
		#include "arrow/compute/exec/exec_plan.h" // IWYU pragma: export
		#include "arrow/compute/exec/groupby.h" // IWYU pragma: export