Add support for Gutenberg block alignment #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
reviewed
Jul 2, 2020
src/index.js
Outdated
Comment on lines
150
to
154
| supports: { | ||
| ...settings.supports, | ||
| align: true, | ||
| }, | ||
|
|
There was a problem hiding this comment.
Is this test code?
Suggested change
| supports: { | |
| ...settings.supports, | |
| align: true, | |
| }, |
There was a problem hiding this comment.
Oops, my bad. Removed that commit 👍
allejo
force-pushed
the
fix/gutenberg-alignment
branch
from
d5f5549
to
c1152ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HighlightablePlainTextcomponent was accidentally creating a new ref each time by callingcreateRef. We should have been usinguseRef, which will always return the same ref for us to use on each re-render. Since changing alignment Gutenberg causes a new instance of the component to mount, we shouldn't be creating a new reference each time.Also added support for using block alignment.
Fixes #128
/cc @grgarside