Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename remaining references of "selected" to "highlighted" #95

Merged
merged 13 commits into from
May 6, 2020

Conversation

westonruter
Copy link
Owner

This PR amends #92 to further fix #84.

Also:

  • Use background instead of bg.
  • Disambiguate get_option() function from core by renaming to get_plugin_option(). Also prevent non-existent option from causing PHP error.
  • Reduce syntax_highlighting_code_selected_line_bg filter to syntax_highlighted_line_background_color.
  • Remove unused shcb-selected-lines class name.
  • Fix insertion of styles when not in development mode.

@westonruter westonruter requested a review from allejo May 6, 2020 18:22
@allejo
Copy link
Collaborator

allejo commented May 6, 2020

I added f67b59d because this was the second time we had forgot to update our transient rendering 😅

@westonruter westonruter merged commit adda4e2 into master May 6, 2020
@westonruter westonruter deleted the update/selected-symbol-names branch May 6, 2020 20:33
@westonruter
Copy link
Owner Author

I added f67b59d because this was the second time we had forgot to update our transient rendering 😅

I just realized that I did the same essentially in 36f536f as part of #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm identifiers for attributes
2 participants