Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't navigate from splash page on the demo site #11

Open
jvanulde opened this issue Feb 21, 2020 · 7 comments · May be fixed by #28
Open

Can't navigate from splash page on the demo site #11

jvanulde opened this issue Feb 21, 2020 · 7 comments · May be fixed by #28
Assignees
Labels
bug Something isn't working

Comments

@jvanulde
Copy link
Member

Describe the bug
Demo site returns a 404 when navigating from the splash page

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://wet-boew.github.io/gcweb-jekyll/
  2. Click on a language button
  3. See error
@delisma delisma self-assigned this Feb 21, 2020
@delisma delisma added the bug Something isn't working label Feb 21, 2020
@delisma
Copy link

delisma commented Feb 21, 2020

I see the bug. The link should bring you to https://wet-boew.github.io/gcweb-jekyll/en/ instead of https://wet-boew.github.io/en/. I would need to explore the relative_url setting to see why it's not linking to the right folder. Have you try it locally to see if it does the same thing? For a stange reason Jekyll doesn't treat relative_url the same way locally (vs hosted on Github)

In the meantime, if you do need to use the theme, you can always use the theme as a remote theme (see the canada-ca-jekyll-boilerplate).

@delisma delisma closed this as completed Feb 21, 2020
@delisma delisma reopened this Feb 21, 2020
@jvanulde
Copy link
Member Author

@delisma the local build works as expected.

@jvanulde
Copy link
Member Author

@delisma is this a possible solution: jekyll/jekyll#332 (comment)

@jvanulde
Copy link
Member Author

Got the splash page to function as expected by adding {{ site.baseurl }} in front of all relative internal links. In config.yml I set baseurl to my GitHub project name. To deploy locally I do bundle exec jekyll serve --baseurl '' so that I can browse the site prior to committing to GitHub pages.

@anthonyfok
Copy link

Looks like this is fixed?
As of today (2021-02-17), on the https://wet-boew.github.io/gcweb-jekyll/ demo site,
clicking on either the English or French button works.
So, perhaps this issue can be closed? :-)

@delisma
Copy link

delisma commented Feb 17, 2021

Thank you @anthonyfok but I will still monitor this issue until next week when the new update is completed.

@jvanulde
Copy link
Member Author

Looks like this is hasn't been fixed for the language toggle (i.e. inc-languagetoggle.html). I tried using baseurl variable but it actually concatenates it twice.

delisma pushed a commit that referenced this issue Jun 18, 2021
delisma pushed a commit that referenced this issue Jun 18, 2021
delisma pushed a commit that referenced this issue Jun 18, 2021
delisma pushed a commit that referenced this issue Jun 18, 2021
@delisma delisma linked a pull request Jun 18, 2021 that will close this issue
4 tasks
@delisma delisma linked a pull request Jun 18, 2021 that will close this issue
4 tasks
@delisma delisma reopened this Jun 18, 2021
delisma pushed a commit that referenced this issue Jun 21, 2021
delisma pushed a commit that referenced this issue Jun 21, 2021
delisma pushed a commit that referenced this issue Jun 22, 2021
delisma pushed a commit that referenced this issue Jun 22, 2021
delisma pushed a commit that referenced this issue Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants