Add relative_url in language switcher #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delisma
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on a little example site using the gcweb jekyll theme for internal use and noticed that the alt lang url doesn't use the relative_url filter like the breadcrumbs do.
That means for sites using subdirectories like most github pages the alt lag url omits the baseurl. For sites running at the root there's no impact from this bug.
I added a note in the default _config.yml file about the value you might set baseurl to as well.
Possible risk: Impact on a site is minimal but for content that has already been created where the baseurl has been manually addded to the altlang url then the content would have to be updated.