-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hale»connect API documentation #71
Conversation
ING-4009
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will the German translation be added in this PR as well? If so, it can be done under the same folder tree in i18n/de/docusaurus-plugin-content-docs/current/
.
|
||
Enter this URL in your favorite browser: https://haleconnect.com/swagger/ | ||
|
||
For on-premise users, enter: https://[yourdomain]/swagger/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on if they have enabled it.
|
||
Attachment: https://haleconnect.com/store/attachments/swagger.yaml | ||
|
||
A bucket is a container for objects stored in Amazon S3. The hale»connect bucket service APIs provide access to files and datasets associated with each resource type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe more general referring to "file storage" instead of "Amazon S3"? The internals don't really matter for the API and depending on the setup AWS is not used.
|
||
The interaction service provides access to comments, tasks and notes on a given resource, as well as the forum. | ||
|
||
### Notification service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe leave this one out. There aren't really any useful endpoints for end users I think.
### Workflow manager | ||
workflow_manager: https://haleconnect.com/workflows/swagger.yaml | ||
|
||
The workflow manager service enables users to access information about ETF Validator and Spatineo monitoring. The generic workflows.....???? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow manager is responsible for managing most tasks in the platform like transformations, validation, status updates etc.
|
||
For on-premise users, enter: https://[yourdomain]/swagger/ | ||
|
||
Select Login, and provide your hale»connect user name and password to obtain an authentication token. Click in the Model Schema field on the right hand side to copy the code template to the body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it guaranteed that they will see the Login endpoint when they open swagger? Otherwise maybe include: if you don't see the login endpoint already, enter in the top bar URL input _https://haleconnect.com/accounts/swagger.yaml_, and click on explore.
|
||
The hale»connect platform can be accessed via API. The hale»connect API enables users to automatically execute workflows, change configuration settings, manage organisations and users, and many other tasks. A series of access URLs permit access to various platform functionality exposed via API. To begin exploring the hale»connect API, it is necessary to log-in using your hale»connect user name and password, in Swagger. | ||
|
||
Enter this URL in your favorite browser: https://haleconnect.com/swagger/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe include a general note for the whole document: Throughout the document _https://haleconnect.com_ is used as domain, but replace it with your own custom domain if you have one.
ING-4009
@stempler @morch23mj I added your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, I left some comments.
Would it maybe make sense to also quickly introduce the different types of requests (POST, GET,...) that can be made? Not sure if users not used to swagger yet would know where to start/what to do right away even if they know which service is serving for what.
|
||
--- | ||
|
||
The hale»connect platform can be accessed via API. The hale»connect API enables users to automatically execute workflows, change configuration settings, manage organisations and users, and many other tasks. A series of access URLs permit access to various platform functionality exposed via API. To begin exploring the hale»connect API, it is necessary to log-in using your hale»connect user name and password, in Swagger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A series permit -> a series permits ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To begin exploring the hale»connect API, it is necessary to log-in using your hale»connect user name and password, in Swagger.
Is it really necessary to use/log in to swagger? We do use many API calls to update resources on the platform etc. without using swagger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohannaOtt
A series of access URLs (plural subject) = permit (plural verb conjugation)
Can you provide a description of other ways you use the hc apis? Or what you would like added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is interesting, thanks for explaining. In German, it would be singular verb conjugation because it is only 1 series.
Can you provide a description of other ways you use the hc apis?
Some examples of using API calls without swagger are for example available in this and this guru card and many more are used in the update tool box we are using in the service team. I assume there are also endpoints available for all of them in swagger (not sure at all though)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some examples of using API calls without swagger are for example available in this and this guru card and many more are used in the update tool box we are using in the service team. I assume there are also endpoints available for all of them in swagger (not sure at all though)?
@stempler I have a few questions:
Should curl instructions be added here, or to a separate page about using the hc api with curl?
Are all endpoints listed in the guru cards also available in Swagger?
Does the hc api support any HTTP operations beyond GET, POST, PUT and DELETE? These are the only 4 I can see in Swagger....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should curl instructions be added here, or to a separate page about using the hc api with curl?
Swagger will show a curl example why trying out a request. Generally I think we should focus on the Swagger/OpenAPI documentation for details and not maintain something else in addition.
Are all endpoints listed in the guru cards also available in Swagger?
Usually yes. There may be some exceptions.
The documentation in the Guru cards probably adds some more information about what the endpoints do any what they are for.
@JohannaOtt I will add a section about the different types of requests. |
@JohannaOtt @stempler I believe I have added all requested changes now, so it would be great if you could give another once over. Once approved, I will go ahead and do the DE translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor spelling/wording comments. Overall LGTM
wetransform can enable use of the hale»connect API for on-premise customers upon request. | ||
|
||
|
||
Select Login, and provide your hale»connect user name and password to obtain an authentication token. If the Login endpoint is not visible, enter https://haleconnect.com/accounts/swagger.yaml in the URL input field at the tope of the page and click on «Explore». Click in the Model Schema field on the right hand side to copy the code template to the body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the tope - at the top?
|
||
The GET operation requests the retrieval of data. | ||
|
||
The POST operation requests that a server accept data contained in the request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accept - accepts?
|
||
The DELETE operation requests deletion of a state or resource. | ||
|
||
When working in Swagger, we recommend examining the endpoint, the HTTP operation and the written description of the endpoint available for each entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we - wetransform? Not sure if we are usually using first person in the documentation.
@JohannaOtt OK, great. I added the last changes. |
This PR adds documentation about the hale»connect API and how to use it.
ING-4009