-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matching alignment with gid712 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, just two minor changes needed before we can merge.
build.gradle
Outdated
} | ||
dependencies { | ||
classpath 'to.wetransform.hale:gradle-hale-plugin:1.1.3' | ||
classpath 'to.wetransform.hale:gradle-hale-plugin:1.2.0-SNAPSHOT' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a proper release of the gradle-hale-plugin in the meantime, so this can be changed to classpath 'to.wetransform.hale:gradle-hale-plugin:2.0.0'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint. I changed it now.
database/testbed/docker-compose.yml
Outdated
- "15432:5432" | ||
environment: | ||
POSTGRES_PASSWORD: postgres | ||
version: '3.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version
property is obsolete. To avoid the warning
WARN[0000] /path/to/postnas-inspire-alignments/database/testbed/docker-compose.yml: `version` is obsolete
when using a recent Docker version, it should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint. I changed this.
edc218e
to
5b28a3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SVC-1698
SVC-1698
Also the old sql files are renamed. SVC-1732
The description of some attributes of PostNAS schema 7.1 are wrong. This is corrected here to allow a correct dbMatching between the original NAS schema and the PostNAS schema. SVC-1732
5b28a3d
to
0982e81
Compare
🎉 This PR is included in version 7.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
SVC-1732