Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matching alignment with gid712 #10

Merged
merged 10 commits into from
May 13, 2024
Merged

Update matching alignment with gid712 #10

merged 10 commits into from
May 13, 2024

Conversation

annat2022
Copy link
Member

SVC-1732

@annat2022 annat2022 requested a review from florianesser May 6, 2024 11:55
Copy link
Member

@florianesser florianesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just two minor changes needed before we can merge.

build.gradle Outdated
}
dependencies {
classpath 'to.wetransform.hale:gradle-hale-plugin:1.1.3'
classpath 'to.wetransform.hale:gradle-hale-plugin:1.2.0-SNAPSHOT'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a proper release of the gradle-hale-plugin in the meantime, so this can be changed to classpath 'to.wetransform.hale:gradle-hale-plugin:2.0.0'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint. I changed it now.

- "15432:5432"
environment:
POSTGRES_PASSWORD: postgres
version: '3.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version property is obsolete. To avoid the warning

WARN[0000] /path/to/postnas-inspire-alignments/database/testbed/docker-compose.yml: `version` is obsolete

when using a recent Docker version, it should be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint. I changed this.

@annat2022 annat2022 requested a review from florianesser May 13, 2024 13:41
Copy link
Member

@florianesser florianesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annat2022 annat2022 merged commit 728e29f into master May 13, 2024
1 check passed
@annat2022 annat2022 deleted the migration-gid712 branch May 13, 2024 15:25
Copy link

we-release bot commented Sep 16, 2024

🎉 This PR is included in version 7.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@we-release we-release bot added the released label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants