-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse Abi
with zod
as readonly
array
#197
Conversation
|
Bug Fixes
Chore
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 21 21
Lines 2055 2061 +6
Branches 325 325
=======================================
+ Hits 2053 2059 +6
Misses 2 2
☔ View full report in Codecov by Sentry. |
Abi
with zod
as readonly
array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Might make sense to re-open this PR against the current main
branch since the repo structure changed a bit.
Sure, I will take a look soon. |
6337ccf
to
f8abb47
Compare
Description
This PR sets the
zod
Abi
schema fromabitype/zod
asreadonly []
to match theAbi
type declared inabitype
.Additional Information
Your ENS/address: windyy.eth
PR-Codex overview
Focus of the PR:
This PR focuses on making changes to the
Abi
parsing in the code, usingzod
as areadonly
array.Detailed summary:
Abi
withzod
as areadonly
array.z.switch
(Deprecatingz.discriminatedUnion
? colinhacks/zod#2106).AbiFunction | AbiConstructor | AbiFallback | AbiReceive
sincez.discriminate
doesn't supportz.preprocess
onoptions
(discriminatedUnion
produces TS error when.default
or.preprocess
are applied colinhacks/zod#1490).stateMutability
for deprecated fields:constant
andpayable
.