Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse Abi with zod as readonly array #197

Closed
wants to merge 0 commits into from

Conversation

matbour
Copy link

@matbour matbour commented Oct 10, 2023

Description

This PR sets the zod Abi schema from abitype/zod as readonly [] to match the Abi type declared in abitype.

Additional Information

  • I read the contributing guide
  • I added documentation related to the changes made.
  • I added or updated tests related to the changes made.

Your ENS/address: windyy.eth


PR-Codex overview

Focus of the PR:

This PR focuses on making changes to the Abi parsing in the code, using zod as a readonly array.

Detailed summary:

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

⚠️ No Changeset found

Latest commit: f8abb47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@commit-lint
Copy link

commit-lint bot commented Oct 10, 2023

Bug Fixes

  • parse Abi with zod as readonly array (251be35)

Chore

Contributors

mathieu-bour

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abitype ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 8:43pm

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e2797ef) 99.90% compared to head (6337ccf) 99.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          21       21           
  Lines        2055     2061    +6     
  Branches      325      325           
=======================================
+ Hits         2053     2059    +6     
  Misses          2        2           
Files Coverage Δ
src/zod.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbour matbour changed the title fix: parse Abi with zod as readonly array fix: parse Abi with zod as readonly array Oct 10, 2023
@matbour matbour marked this pull request as ready for review October 10, 2023 08:16
Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might make sense to re-open this PR against the current main branch since the repo structure changed a bit.

@matbour
Copy link
Author

matbour commented Oct 11, 2023

Sure, I will take a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants