-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(siwe): createSiweMessage domain validation #2299
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: fdfcbab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c9756ee
to
fdfcbab
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2299 +/- ##
==========================================
- Coverage 99.70% 97.12% -2.58%
==========================================
Files 680 675 -5
Lines 57684 57295 -389
Branches 2749 2455 -294
==========================================
- Hits 57511 55647 -1864
- Misses 156 1630 +1474
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. |
Domain validation was overly restrictive.
Fixes #2295
PR-Codex overview
This PR focuses on fixing
createSiweMessage
domain
validation by adding tests for valid and invalid domains and updating the regex patterns.Detailed summary
createSiweMessage.test.ts
createSiweMessage
to validate domains using new regex patternsipRegex
andlocalhostRegex
for domain validation