Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getEip712Domain #2399

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: getEip712Domain #2399

merged 1 commit into from
Jun 13, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Jun 13, 2024

PR-Codex overview

The focus of this PR is to add the getEip712Domain action and related functionality.

Detailed summary

  • Added getEip712Domain action to read EIP-712 domain from a contract.
  • Updated client decorators and tests.
  • Added Mock4337Account and Mock4337AccountFactory.
  • Updated documentation and error handling for getEip712Domain.

The following files were skipped due to too many changes: src/actions/public/getEip712Domain.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Jun 13, 2024 4:59am

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 7ee11c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 57.21 KB (+0.51% 🔺) 1.2 s (+0.51% 🔺) 1.2 s (-47.32% 🔽) 2.3 s
viem (cjs) 68.54 KB (+0.44% 🔺) 1.4 s (+0.44% 🔺) 2.3 s (-10.41% 🔽) 3.7 s
viem (minimal surface - tree-shaking) 3.31 KB (0%) 67 ms (0%) 17 ms (-65.9% 🔽) 83 ms
viem/accounts 73.64 KB (0%) 1.5 s (0%) 596 ms (+28.32% 🔺) 2.1 s
viem/accounts (tree-shaking) 18.91 KB (0%) 379 ms (0%) 134 ms (-48.75% 🔽) 512 ms
viem/actions 41.73 KB (0%) 835 ms (0%) 555 ms (+115.15% 🔺) 1.4 s
viem/actions (tree-shaking) 318 B (0%) 10 ms (0%) 5 ms (+43.98% 🔺) 15 ms
viem/chains 28.49 KB (0%) 570 ms (0%) 268 ms (-53.92% 🔽) 838 ms
viem/chains (tree-shaking) 324 B (0%) 10 ms (0%) 4 ms (-13.8% 🔽) 14 ms
viem/chains/utils 1.02 KB (0%) 21 ms (0%) 8 ms (+26.43% 🔺) 28 ms
viem/ens 41.73 KB (0%) 835 ms (0%) 690 ms (+231.68% 🔺) 1.6 s
viem/ens (tree-shaking) 18.42 KB (0%) 369 ms (0%) 156 ms (-40.21% 🔽) 524 ms
viem/siwe 26.56 KB (0%) 532 ms (0%) 353 ms (+66.41% 🔺) 884 ms
viem/siwe (tree-shaking) 25.42 KB (0%) 509 ms (0%) 374 ms (-25.58% 🔽) 882 ms

@jxom jxom merged commit a61a90c into main Jun 13, 2024
19 of 32 checks passed
@jxom jxom deleted the erc-5267 branch June 13, 2024 05:36
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant