-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(extension): Account Abstraction #2510
Conversation
🦋 Changeset detectedLatest commit: 560363f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
+ Coverage 99.66% 99.67% +0.01%
==========================================
Files 716 749 +33
Lines 59689 67661 +7972
Branches 2852 3209 +357
==========================================
+ Hits 59488 67441 +7953
- Misses 187 207 +20
+ Partials 14 13 -1 ☔ View full report in Codecov by Sentry. |
011f8d7
to
77f0a29
Compare
f81c6ae
to
620683d
Compare
7a4d254
to
7191015
Compare
e8756fa
to
c390ce1
Compare
c390ce1
to
d0ed794
Compare
d0ed794
to
642a7bd
Compare
1aff78e
to
45ad74a
Compare
45ad74a
to
d704894
Compare
f437375
to
60ae017
Compare
the examples provided (https://viem.sh/account-abstraction/accounts/webauthn/createWebAuthnCredential) do no work neither in firefox nor in chrome:
On firefox it throws
|
@Silur – example app that uses this snippet works for me: CleanShot.2024-08-09.at.09.47.31.mp4 |
export function createPaymasterClient( | ||
parameters: PaymasterClientConfig, | ||
): PaymasterClient { | ||
const { key = 'bundler', name = 'Bundler Client', transport } = parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intentionally named like the bundler client rather than a paymaster client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "paymaster"
Adds support for an ERC-4337 Account Abstraction extension.
See Docs