Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeploylessUniversalSigValidator.sol
behavior does not currently match the spec, in that it does not call the factory if the account is already deployed.According to the EIP, for the signer
and the verifier should call this "factory" with the calldata if the magic bytes are present
This PR currently just attempting to creating a broken test demonstrating the issue.
PR-Codex overview
Summary
Fixes ERC6492 verification and prepares for user operation gas estimation.
Detailed summary
verifyHash.ts
estimateUserOperationGas.test.ts
verifyHash.test.ts
verifyHash.test.ts
verifyHash.test.ts