Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-stack): handle InvalidGameType #2631

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix(op-stack): handle InvalidGameType #2631

merged 2 commits into from
Aug 20, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Aug 19, 2024


PR-Codex overview

This PR handles the InvalidGameType error in getWithdrawalStatus and updates functions and events in the OP Stack.

Detailed summary

  • Added handling for InvalidGameType error in getWithdrawalStatus
  • Updated function types and state mutability in abis.ts for clarity and correctness

The following files were skipped due to too many changes: src/op-stack/abis.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 320b727

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Aug 20, 2024 1:51am

Copy link
Contributor

github-actions bot commented Aug 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 60.33 KB (0%) 1.3 s (0%) 6.8 s (-60.19% 🔽) 8 s
const viem = require('viem') (cjs) 71.13 KB (0%) 1.5 s (0%) 24.9 s (+72.62% 🔺) 26.4 s
import { createClient, http } from 'viem' 6.22 KB (0%) 125 ms (0%) 340 ms (-74.12% 🔽) 464 ms
import * from 'viem/account-abstraction' 43.72 KB (0%) 875 ms (0%) 9.7 s (+261.48% 🔺) 10.5 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 34 KB (0%) 680 ms (0%) 6.4 s (-22.01% 🔽) 7.1 s
import * from 'viem/accounts' 74.45 KB (0%) 1.5 s (0%) 7.1 s (+128.61% 🔺) 8.6 s
import { privateKeyToAccount } from 'viem/accounts' 19.37 KB (0%) 388 ms (0%) 1.7 s (-7.99% 🔽) 2.1 s
import * from 'viem/actions' 45.92 KB (0%) 919 ms (0%) 8.6 s (+56.59% 🔺) 9.5 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 31 ms (-48.65% 🔽) 41 ms
import * from 'viem/chains' 31.09 KB (0%) 622 ms (0%) 5.6 s (-38.51% 🔽) 6.2 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 42 ms (-3.23% 🔽) 52 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 78 ms (+4.37% 🔺) 99 ms
import * from 'viem/ens' 45.43 KB (0%) 909 ms (0%) 3 s (-40.93% 🔽) 4 s
import { getEnsAvatar } from 'viem/ens' 22.12 KB (0%) 443 ms (0%) 6.6 s (+18.96% 🔺) 7 s
import * from 'viem/siwe' 30.21 KB (0%) 605 ms (0%) 6.9 s (+1.46% 🔺) 7.6 s
import { verifySiweMessage } from 'viem/siwe' 29.18 KB (+0.17% 🔺) 584 ms (+0.17% 🔺) 8.3 s (+37.17% 🔺) 8.9 s

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 99.70149% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.54%. Comparing base (9c65170) to head (320b727).
Report is 1 commits behind head on main.

Files Patch % Lines
src/op-stack/actions/getWithdrawalStatus.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2631      +/-   ##
==========================================
- Coverage   99.66%   97.54%   -2.12%     
==========================================
  Files         774      770       -4     
  Lines       69581    70003     +422     
  Branches     3274     2966     -308     
==========================================
- Hits        69347    68286    -1061     
- Misses        220     1687    +1467     
- Partials       14       30      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant