fix: Always use maxUint256 instead of 2n ** 256n - 1n #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve code readability - Fix error: *identifier starts immediately after numeric literal*
🦋 Changeset detectedLatest commit: c69e8e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@frapsMatheus is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Sep 7, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the readability of code that uses
2n ** 256n - 1n. It also fixes a crash in JavaScript caused by using these big numbers directly insideifstatements.Summary
PR-Codex overview
This PR replaces hard-coded values with a
maxUint256constant for fee calculations.Detailed summary
maxUint256constant in fee calculations across multiple files.