Fix LRU cache not updating touched keys #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 48e179a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@kyscott18 is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Sep 5, 2024
Merged
Merged
Merged
holic
reviewed
Sep 8, 2024
| override get(key: string) { | ||
| const value = super.get(key) | ||
|
|
||
| if (value !== undefined) { |
There was a problem hiding this comment.
curious if this should use super.has(key) instead to account for LruMap<undefined>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LRU algorithm in
utils/lru.tsdoes not update touched keys, it instead is acting like a "first recently used" algorithm.PR-Codex overview
This PR focuses on fixing the LRU algorithm in
LruMapby updating touched keys.Detailed summary
LruMapto properly update touched keys in the LRU algorithm.override getmethod to handle key updates.