Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EIP712): do not allow extraneous attributes #3222

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

freemanzMrojo
Copy link
Contributor

Added a test with what I mean, title is self-explanatory.

Copy link

vercel bot commented Jan 13, 2025

@freemanzMrojo is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: ab857ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@freemanzMrojo freemanzMrojo changed the title fix(EIP712): do not allow extraneous attributes for domain fix(EIP712): do not allow extraneous attributes Jan 14, 2025
@freemanzMrojo freemanzMrojo requested a review from jxom January 14, 2025 12:07
@freemanzMrojo
Copy link
Contributor Author

Hi @jxom , hope you had a good weekend!

Please, let me know if I should do something else, thanks!

@freemanzMrojo
Copy link
Contributor Author

Hey @jxom , hope you are doing well! If you think I should close this PR, please let me know 🙏 . Thanks!

@jxom jxom force-pushed the main branch 2 times, most recently from fecd0e5 to 22ef4ac Compare February 21, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants