Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify Alchemy provider's api key to be mapped by chain. #2808

Closed
wants to merge 1 commit into from

Conversation

siosio34
Copy link
Contributor

Description

hello. I am using alchemyProvider, but inside alchemy, it is recommended to use different API Keys for each chain, so I changed the internal source.

The documentation code has not been included yet, but if the reflection of the code is judged to be okay, we will also modify the docs.

If you want to support the type of the previous version of the syntax, you can do additional work, but after contacting Alchemy, it seems that it is not encouraged. Same.

Finally, thank you for making a good open source. Thanks to you, my working hours are shorter.

Additional Information

Your ENS/address:

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: 0258af7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 26, 2023

@siosio34 is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@tmm
Copy link
Member

tmm commented Jul 26, 2023

Appreciate the PR! The concept of providers per service like this will be removed in v2. It's more trouble than it's worth to hardcode RPC base URLs internally and much better folks specify full RPC URLs. In the meantime, you can use the jsonRpc provider. existing pattern comes from when wagmi used ethers internally.

@tmm tmm closed this Jul 26, 2023
@siosio34
Copy link
Contributor Author

@tmm Thank you for your review. ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants