Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide correct block explorer URL to WalletConnect #3341

Merged
merged 3 commits into from
Dec 22, 2023
Merged

fix: provide correct block explorer URL to WalletConnect #3341

merged 3 commits into from
Dec 22, 2023

Conversation

chybisov
Copy link
Contributor

Description

Fixes the WalletConnect connector issue #3340 when calling switchChain for a chain that is not approved during initialization. We need to provide an actual block explorer URL instead of a block explorer object to an array of URLs.

Additional Information

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 62cb4c1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 2:12pm

@vercel Vercel
Copy link

vercel bot commented Dec 22, 2023

@chybisov is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@chybisov chybisov mentioned this pull request Dec 22, 2023
Closed
1 task
@chybisov
Copy link
Contributor Author

We are doing the same in the Coinbase connector as well. https://github.com/wevm/wagmi/blob/rc/packages/connectors/src/coinbaseWallet.ts#L177

Should I fix it there too? 👀

@tmm tmm merged commit 0442405 into wevm:rc Dec 22, 2023
4 of 5 checks passed
@chybisov chybisov mentioned this pull request Dec 22, 2023
Merged
1 task
@chybisov
Copy link
Contributor Author

@tmm fix for Coinbase #3342 🙂

tmm added a commit that referenced this pull request Jan 4, 2024
@tmm @jxom
@o-az @aquaticone @snkashis @ignaciosantise @marthendalnunes @omridan159 @chybisov @POKENA7
wagmi@2.0.0 release candidate (#3333)
b3a0baa 
* chore: format

* chore: tweaks

* refactor: injected

* fix: type error

* refactor: remove injected features array

* feat: reactive connectors

* chore: playground

* feat: ssr playground

* chore: mark package as private

* chore: knip

* chore: clean up

* docs: add bun to install options

* refactor: reconnect behavior

* chore: tweaks

* chore: format

* feat: eip6963 support

* chore: version

* docs: start migration guides

* chore: remove unused package

* chore: update readme

* chore: update snaps

* docs: useContractRead

* docs: reorganize sidebar (#3031)

* docs: sidebar

* trigger

---------

Co-authored-by: moxey.eth <jakemoxey@gmail.com>

* docs: connectors

* docs: connectors

* docs: code-group spacing

* docs: move connectors sidebar

* chore: tweaks

* docs: estimateGas

* docs: client

* docs: watch

* docs: client

* docs: wip

* chore: bump viem

* docs: writeContract

* chore: sidebar

* docs: more

* test: types

* docs: migration guide

* docs: migrate

* docs: migrate

* docs: useAccountEffect

* docs: useContractWrite

* docs: useContractWrite update

* docs: useContractSimulate

* chore: fix test

* docs: update

* docs: updates

* docs: tweaks

* docs: more

* docs: updates

* docs: versions

* chore: update playground

* chore: bump deps

* docs: migrate

* docs: mock connector

* chore: fix import

* chore: add og meta

* docs: og

* docs: update colors

* chore: bump version

* docs: updates

* chore: update preconstruct script

* docs: update

* docs: update

* docs: add missing sponsors

* chore: add missing logo

* feat: error types

* refactor: rename contract hooks

* chore: version

* chore: rename test hooks

* feat: create-wagmi@alpha (#3071)

* wip: create-wagmi

* wip: cli

* wip: templates

* chore: update templates

* feat: create-wagmi@alpha

* chore: up snaps

* chore: format

* chore: update template

* chore: bump actions checkout

* chore: add template envs

* test: create-wagmi

* fix: test build

* chore: knip

* test: fix

* chore: remove note

* docs: reorder sidebar

* chore: changes

* chore: rename

* chore: type updates

* chore: bump ts

* chore: add ts 5.0.4 back

* chore: clean up

* feat(connectors): metaMask

* test: metaMask

* chore: bump create-wagmi

* docs: useTransaction/useWaitForTransactionReceipt

* docs: query options

* docs: config

* docs: small updates

* docs: useWalletClient/useConnectorClient

* docs: hide query properties

* chore: version

* docs: tanstack query

* chore: bump metamask sdk version

* docs: viem

* chore: update viem

* docs: react viem

* docs: ethers

* docs: ethers react

* docs: word

* chore: updates

* chore: bump viem

* docs: cli

* docs: tweaks

* docs: plugins

* docs: plugins

* docs: progress

* docs: clean up

* chore: version

* feat: error types

* fix: docs

* chore: version

* docs: error handling

* docs: connect wallet

* trigger

* chore: remove react from docs

* docs: connect wallet

* chore: lockfile

* docs: remove preview

* docs: connect wallet

* feat: ssr

* feat: next ssr

* feat: cookies

* lockfile

* feat: wire up error types

* fix: typecheck

* chore: tweaks

* docs: ssr

* fix: reconnectOnMount=false

* chore: update query

* docs(wip): infinite read contracts

* docs: useInfiniteReadContracts cont.

* docs: useReadContracts

* chore: tweaks

* docs: rest of hooks & actions

* chore: bump viem

* chore: bump versions

* chore: beta release

* chore: tweaks

* fix: doc link missing /api path (#3185)

* docs: update search

* fix(react): useReadContracts chainId

* chore: bump version

* chore: comment

* chore: bump viem version

* fix: mipd subscribe

* chore: bump versions

* chore: consistent versions

* chore: bump version

* chore: ts version

* chore: bump viem version

* fix: #3216

* fix(react): internal types

* fix: useWaitForTransactionReceipt enabled state (#3188)

* fix: useWaitForTransactionReceipt enabled state

* test: update

---------

Co-authored-by: Tom Meagher <tom@meagher.co>

* chore: bump version

* Fix 404 for "Caching. Deduplication. Persistence" section on beta landing page (#3233)

* fix: use rpcUrls.default when requesting wallet_addEthereumChain (#3251)

* chore: username

* fix: disconnect eagerly (#3255)

* fix: eager disconnect

* chore: update tests

* chore: wagmi-dev to wevm

* ci: update verify

* chore: snaps

* chore: add sponsor

* docs: update

* chore: update viem

* chore: update viem

* chore: update viem

* chore: update viem

* refactor: updated walletconnect connector (#3277)

* Add `getTransactionCount` and `useTransactionCount` (#3271)

* feat: add getTransactionCount to core

* feat: add getTransactionCount to core

* feat: add useTransactionCount to react hooks

* docs: add useTransactionCount

* fix: useTransactionCount formatting

* fix: add getTransactionCount to exports tests

* chore: add changeset

* chore: remove changeset

* chore: remove wrapping describe

* chore: fix spacing

* fix: add retry/timeout strategy for injected connector initialization

* feat: unstable_connector transport

* chore: update snaps

* feat: upgrade @metamask/sdk package to version '0.12.4' (#3237)

* feat: upgrade @metamask/sdk package to version '0.12.2'

* chore: code clean

* chore: remove the extensionOnly option

* fix: sdk is not disconnecting

* feat: upgrade @metamask/sdk package to version '0.12.4'

* feat: bump version

---------

Co-authored-by: Tom Meagher <tom@meagher.co>

* chore: publish

* chore: update script

* chore: reshuffle type util

* test: fix flaky test

* fix(cli): import issue

* chore: version

* docs: update

* test: update

* test: update

* chore: update unstable_connector transport test

* feat(cli): react plugin - wagmi@beta (#3217)

* feat(cli): react plugin

* refactor: import builder

* chore: bump msw

* refactor: create fns

* chore: checkpoint

* test: create types

* wip: refactor

* chore: tweaks

* test(cli): react plugin

* test: fix

* chore(connectors): bump deps

* fix(connectors): remove ledger

* chore: version

* chore: knip

* chore: update

* chore: lock deps

* ci: checks

* chore: lint fix

* ci: bump timeout

* chore: tweak

* test: codegen

* fix: sim codegen hook

* feat: createWatchContractEvent

* chore: readme

* feat(cli): plugins

* chore: add sponsors

* feat(cli): actions plugin

* chore: up sponsors

* docs: switch to local search

* chore: upgrade viem

* chore: version

* Feat: Add core actions and hooks for `getBlockTransactionCount`, `getGasPrice`, `getFeeHistory` and `estimateMaxPriorityFeePerGas` (#3290)

* feat: add getBlockTransactionCount

* feat: add useBlockTransactionCount

* feat: add getGasPrice

* feat: add useGasPrice

* feat: add getFeeHistory

* feat: add useFeeHistory

* feat: add estimateMaxPriorityFeePerGas

* feat: add useEstimateMaxPriorityFeePerGas

* test: updates

---------

Co-authored-by: Tom Meagher <tom@meagher.co>

* docs: transports

* docs: fix

* Feat: Add core actions and hooks for `verifyMessage` and `verifyTypedData` (#3300)

* feat: add verifyMessage action

* fix: add chainId param to verifyMessage

* feat: add useVerifyMessage

* feat: add verifyTypedData

* feat: add useVerifyTypedData

* refactor: types

* docs: update

---------

Co-authored-by: Tom Meagher <tom@meagher.co>

* fix: snaps

* chore: version

* chore: rc

* docs: fix

* fix: provide correct block explorer URL to WalletConnect (#3341)

* fix: provide correct block explorer URL to WalletConnect

* chore: add changeset

* chore: remove references

* fix: provide correct block explorer URL to Coinbase connector (#3342)

* fix: provide correct block explorer URL to Coinbase connector

* chore: add changeset

* chore: version

* chore: snaps

* chore: more snaps

* test: flaky

* chore: bump viem

* chore: version

* chore: fix lockfile

* docs: update

* Fix 404s in createConfig docs (#3355)

* Fix doc link (#3358)

fix: doc link

* Fix missing config argument (#3359)

* chore(connectors): bump deps

* docs: update

* docs: update

* docs: updates

* docs: fix broken links

* docs: fix broken links

* chore: bump viem version

* chore: version

* chore: tweak

* chore: bump viem to stable

* chore: changeset

* docs: add old docs link

---------

Co-authored-by: tmm <tmm@users.noreply.github.com>
Co-authored-by: moxey.eth <jakemoxey@gmail.com>
Co-authored-by: Omar <omaraziz.dev@proton.me>
Co-authored-by: aquatic <95545650+aquaticone@users.noreply.github.com>
Co-authored-by: Steve <snkashis@users.noreply.github.com>
Co-authored-by: ignaciosantise <ignacio.santise@gmail.com>
Co-authored-by: Vitor Marthendal Nunes <marthendalnunes@gmail.com>
Co-authored-by: Omri Dan <61094771+omridan159@users.noreply.github.com>
Co-authored-by: Eugene Chybisov <18644653+chybisov@users.noreply.github.com>
Co-authored-by: POKENA7 <75174441+POKENA7@users.noreply.github.com>
@Ramyromel Ramyromel mentioned this pull request Mar 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chybisov @tmm