Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out duplicate EIP-6963 connectors on mount (server-side) #3683

Closed
wants to merge 2 commits into from
Closed

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Mar 7, 2024

Description

  • During on mount if ssr is true in createConfig the EIP-6963 connectors might be introduced multiple times. This is happening in hydrate.ts. By the time we add them they were already added in createConfig.ts
  • Created a simple function that would filter out duplicated connectors here

Additional Information

Before submitting this issue, please make sure you do the following.

  • Read the contributing guide
  • Added documentation related to the changes made.
  • Added or updated tests (and snapshots) related to the changes made.

Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: 7d52186

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wagmi Patch
@wagmi/core Patch
@wagmi/connectors Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magiziz magiziz changed the title fix: filter out duplicated connectors during on mount with server-side fix: filter out duplicate eip-6963 connectors on mount (server-side) Mar 7, 2024
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 4:53pm

@magiziz magiziz changed the title fix: filter out duplicate eip-6963 connectors on mount (server-side) fix: filter out duplicate EIP-6963 connectors on mount (server-side) Mar 7, 2024
@jxom
Copy link
Member

jxom commented Mar 18, 2024

Closing in favor of #3715

@jxom jxom closed this Mar 18, 2024
jxom added a commit that referenced this pull request Mar 26, 2024
Co-Authored-By: Magomed Khamidov <53529533+KosmosKey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants