Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ankr rpcs #387

Closed
wants to merge 4 commits into from

Conversation

codingwithmanny
Copy link
Contributor

Description

Added Ankr rpc provider support and documentation alphabetically.

Additional Information

  • I read the contributing docs (if this is your first contribution)

Your ENS/address:

codingwithmanny.eth

codingwithmanny added 2 commits April 29, 2022 11:59
Added constant rpcs urls for Ankr

BREAKING CHANGE: 🧨 n
Added Ankr to docs

BREAKING CHANGE: 🧨 n
@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2022

⚠️ No Changeset found

Latest commit: 620ca7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 30, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @tmm on Vercel.

@tmm first needs to authorize it.

Rearranged alphabetical order of package names

BREAKING CHANGE: 🧨 n
@codingwithmanny
Copy link
Contributor Author

@tmm Did you want to wait for the other testnets to be added to ethers to revise this to include the testnets or fair to proceed with these ones and add the additional testnets in a separate PR?

Ethersjs commit with Ankr Providers
ethers-io/ethers.js@d9f45b3

@tmm
Copy link
Member

tmm commented May 2, 2022

@codingwithmanny can wait if cool. @jxom is looking into a streamlined provider and chains API too that might inform some of this.

@codingwithmanny
Copy link
Contributor Author

@tmm would this replace both infura and alchemy providers and potentially support quicknode all in one fell swoop :) ?

If you think it's going to take a while, would be ok if we merged it in the meantime, I have a use-case for it where I want to work with Ankr's premium API which apparently has a load balancer that uses all providers, if one fails, it goes to the next.

Added ankr testnets for ropsten, rinkeby, goerli

BREAKING CHANGE: n
@codingwithmanny
Copy link
Contributor Author

Good news! Testnets were merged in ethers.js 5.6.5
ethers-io/ethers.js#2949 (comment)

@codingwithmanny
Copy link
Contributor Author

@tmm this the direction you were talking about? If so 🔥
#408

@jxom
Copy link
Member

jxom commented May 4, 2022

@tmm this the direction you were talking about? If so 🔥 #408

you are correct!

@tmm tmm force-pushed the main branch 2 times, most recently from 01d3be9 to d071665 Compare May 5, 2022 23:49
@tmm
Copy link
Member

tmm commented May 11, 2022

Closing this as #408 will be released soon. We also need to figure out a process for adding new API providers, RPC urls, etc. to the core.

@tmm tmm closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants