Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coinbase Wallet: Add Support for Instant Onboarding mode #4440

Merged

Conversation

johanneskares
Copy link
Contributor

@johanneskares johanneskares commented Dec 6, 2024

This PR adds support for the instant onboarding mode of Coinbase Smart Wallet. It enables the same behaviour of the Create Wallet button on https://wallet.coinbase.com and skipping the first screen, where around 50% of my userbase clicked the wrong button.

Use like this:

(coinbaseWalletConnector as any).setInstantOnboarding(true);
await connectAsync({ connector: coinbaseWalletConnector });
Google.Chrome.4.mp4

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 1fc3dba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@wagmi/connectors Minor
wagmi Patch
@wagmi/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:11pm

@johanneskares johanneskares changed the title Update coinbaseWallet.ts Coinbase Wallet: Add Support for Instant Onboarding mode Dec 6, 2024
Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #4453 merged, might be better to add an instantOnboarding property to connector.connect so it's discoverable and easier for folks to use.

const { connect, connectors } = useConnect()
connect({
  connector: connectors[0],
  instantOnboarding: true, // <-- `instantOnboarding` type inferred, shows up in autocomplete, etc.
})
const config = createConfig({
  chains: [mainnet],
  connectors: [coinbaseWallet({ ... })],
  transports: { [mainnet.id]: http() },
})

declare module 'wagmi' {
  interface Register {
    config: typeof config
  }
}

.changeset/big-radios-sip.md Outdated Show resolved Hide resolved
.changeset/big-radios-sip.md Outdated Show resolved Hide resolved
@tmm tmm merged commit e3f63a0 into wevm:main Dec 16, 2024
6 of 12 checks passed
@johanneskares
Copy link
Contributor Author

johanneskares commented Dec 24, 2024

just realized @tmm you finished this. Thanks a lot 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants