Updated components/Ballot/PositionItem.jsx to support individual voter opinions. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var position_description = <span></span>; | ||
| if (position.vote_smart_rating) { | ||
| var position_description = <p className=""> |
There was a problem hiding this comment.
This will get hoisted because there is no block scope unless you use let. var will get hoisted outside of the block.
There was a problem hiding this comment.
I have altered this now for your review. Thank you.
Transitioned "var" to "let" per @pertrai1's suggestion.
|
Normally I would wait for someone else to merge, but I am merging this myself now because @pertrai1 already did one review (code updated per those suggestions), and the code is needed for a design discussion first thing in the morning. 👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated components/Ballot/PositionItem.jsx to support individual voter opinions. There is more work to do around displaying Voter and Public Figure positions, but this is a first step.