fix: updates line-height #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraider
force-pushed
the
raid/update-line-height
branch
from
ca46d62 to
dfb683e
Compare
| @@ -8,7 +8,7 @@ $ray-font-stack-sans-serif: 'Apercu', Avenir, -apple-system, BlinkMacSystemFont, | |||
| $ray-font-stack-mono: 'Apercu Mono', SFMono-Regular, Menlo, Monaco, Consolas, | |||
| 'Liberation Mono', 'Courier New', monospace; | |||
| $ray-base-font-size: rem(16px); | |||
| $ray-base-line-height: 1.75rem; | |||
| $ray-base-line-height: 1.618; | |||
There was a problem hiding this comment.
Why change the global line height?
There was a problem hiding this comment.
The global line height should be relative to the element not the base font-size
There was a problem hiding this comment.
So this is an unrelated fix?
There was a problem hiding this comment.
it's somewhat related
alanfriedman
previously approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.