feat(textarea): allow multi-row textarea #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when rows are provided to a textarea, the fixed height is removed and set to "auto"
adamraider
reviewed
Apr 26, 2019
|
@i8ramin this is cool, could you add a story for it in storybook? So we can visually track it with chromatic. |
There was actually already a storybook. It was just using the wrong attribute -- 881e1d2#diff-9008c83448da3b291989f05165b793edR68 |
adamraider
changed the title
adamraider
reviewed
Apr 26, 2019
Co-Authored-By: i8ramin <49030+i8ramin@users.noreply.github.com>
Co-Authored-By: i8ramin <49030+i8ramin@users.noreply.github.com>
|
@allcontributors[bot] please add @i8ramin for code |
|
I've put up a pull request to add @i8ramin! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when rows are provided to a textarea, the fixed height is removed and set to "auto"