Add a CloseWithoutClear copy mode key assignment #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing the copy overlay currently unconditionally clears the viewport, in particular resetting scroll. For the search overlay, we don't necessarily want to scroll back to the prompt after finding a match -- indeed, the old search overlay (which didn't use copy mode) had this behaviour. Add a CloseWithoutClear key assignment which has this desired behaviour, and make it the default for ESC in search mode.
|
This fixes #3502 |
LeszekSwirski
commented
Feb 1, 2024
wez
reviewed
Feb 1, 2024
wez
reviewed
Feb 1, 2024
|
Added a helper and dropped ResetViewport, PTAL (and let me know if you prefer me to squash the individual commits) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Ping |
|
Ping again (@wez) |
|
@wez anything more to do here? |
|
Regular ping for review, @wez |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the copy overlay currently unconditionally clears the viewport,
in particular resetting scroll. For the search overlay, we don't
necessarily want to scroll back to the prompt after finding a match --
indeed, the old search overlay (which didn't use copy mode) had this
behaviour.
Add a CloseWithoutClear key assignment which has this desired behaviour,
and make it the default for ESC in search mode.