Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom prompt for PromptInputLine #6054

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Conversation

mgpinf
Copy link
Contributor

@mgpinf mgpinf commented Aug 28, 2024

Hello @wez

This change introduces an additional optional parameter to set the prompt in the PromptInputLine. If not passed, the default value of "> " is used.

I'm pretty new to rust, and not sure what test cases to add/modify for these.

Please suggest improvements if any

- Introduces an option to set custom prompt text
- If 'prompt' not passed in parameters, default value of "> " used
@mgpinf mgpinf force-pushed the prompt-input-line-custom branch from 50f4cee to c4ccfb4 Compare September 16, 2024 18:39
Copy link
Owner

@wez wez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

docs/config/lua/keyassignment/PromptInputLine.md Outdated Show resolved Hide resolved
@wez wez merged commit 6a12dd1 into wez:main Sep 22, 2024
15 of 19 checks passed
wez added a commit that referenced this pull request Sep 22, 2024
@mgpinf mgpinf deleted the prompt-input-line-custom branch September 23, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants