Do not synthesize window size for MAXIMIZED/FULLSCREEN/TILED states #6182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the responsibility of the Wayland compositor to set the correct size for the window when it is tiled or maximized.
https://wayland.app/protocols/xdg-shell#xdg_toplevel:enum:state also states that in the maximized case, the client needs to obey the geometry provided by the compositor.
Also, in the fullscreen case, with this code in place, Wezterm ends up not taking up the entire screen when there's some kind of bar/panel (easy to reproduce with the default Gnome desktop).
Since the code was added in response to #6108 I have tested this change against Gnome (47.0.1). The other compositors I've tested against are Niri and Sway; With both Niri and Sway, TILED_TOP/BOTTOM/LEFT/RIGHT are set. Sway isn't broken by this code because it doesn't provide suggested_bounds. With Niri,
pending_event.configure.replace((w / 2, h));
always runs, and it is completely impossible to resize the window (other than making it fullscreen).