fix: opening the InputSelector resulted in invalid pane ids #6403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a selector (InputSelector) overlay while having another overlay open the pane you get in the handler is the pane id of the previous overlay which is also cancelled when assigning the overlay which effectively makes it useless.
This is annoying if you need the pane from an InputSelector and the user opens the InputSelector multiple times in a row (perhaps looking to get other options if those are dynamically generated)
This is more of a band-aid I think and it might be a problem more often, maybe we/I can look into addressing this case in a better way.
Any feedback is appreciated :)