Allow passing arguments to git rebase #422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to pass files to rebase. I assume this was a copy-paste error when the rebase function was introduced in the first place.
If non-option arguments are passed to `git forgit rebase`, pass them through directly to `git rebase`, without launching the interactive selector, just like we do for other forgit commands.
cjappl
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Description
If non-option arguments are passed to
git forgit rebase, pass themthrough directly to
git rebase, without launching the interactiveselector, just like we do for other forgit commands.
Along with this, I removed the possibility to pass files to rebase.
IMO there is no need to pass files to rebase. I assume this was a copy-paste
error when the rebase function was introduced in the first place.
Type of change
Test environment