Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

448 fix flaky test #497

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

watcher6280
Copy link

@watcher6280 watcher6280 commented Jan 23, 2024

Description (Proposed Changes)

  • Start using the clock package https://pub.dev/packages/clock when referencing the current time.
  • Initially only applied to make one unit test stable.

Link to the issue :

#448

Checklist

Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.

Costas Korai added 3 commits January 24, 2024 00:44
- The initial time set in the MealForm is defined in
the meal model object provided to the MealForm so both
the test and the meal object had to use clock.now in
order for the fixed value to apply to both.
@watcher6280 watcher6280 marked this pull request as ready for review January 23, 2024 13:57
@rolandgeider rolandgeider linked an issue Jan 23, 2024 that may be closed by this pull request
@rolandgeider rolandgeider merged commit 9f4b7e3 into wger-project:master Jan 23, 2024
2 checks passed
@rolandgeider
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky test
2 participants