Nutrition cleanup & further enhancements #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it doesn't seem to change how it looks on nutrition detail and makes it look proper on nutrition dashboard widget if we really do need such layout controls, maybe they should be done at the call site, rather than the widget implementation?
... because showing all meals by default is a bit too much info
Dieterbe
force-pushed
the
nutrition-cleanup
branch
from
ba7ab24 to
3b70cb3
Compare
Dieterbe
changed the title
both for dashboard widget and nutritional details page
Dieterbe
force-pushed
the
nutrition-cleanup
branch
from
d65260c to
8c5eded
Compare
rolandgeider
reviewed
May 1, 2024
differentiate between a goal being set (but as 0) vs a goal not being set. fixes various correctness issues
This reverts commit 55aac23033dda47895ffb63154fcbc6fe5524d40.
Dieterbe
force-pushed
the
nutrition-cleanup
branch
from
5fd6e6f to
cb3493b
Compare
Dieterbe
force-pushed
the
nutrition-cleanup
branch
from
cb3493b to
1ae3eaf
Compare
* no need to see the ingredients of every meal in such detail by default * also, handle it nicer when a meal has no ingredients defined yet
Dieterbe
force-pushed
the
nutrition-cleanup
branch
from
4ecfcf5 to
de40b40
Compare
to make golden tests work, we no longer plot the "now time" for "other logs" this was pretty silly anyway...
Dieterbe
force-pushed
the
nutrition-cleanup
branch
from
de40b40 to
25aa08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (Proposed Changes)
Link to the issue :
(Add link of the issue you have proposed changes to)
Tests
Please make sure to add tests when implementing new features.
Checklist
Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).