Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log meal: separate confirmation page with portion choice #593

Merged
merged 1 commit into from
May 29, 2024

Conversation

Dieterbe
Copy link
Contributor

log meal: separate confirmation page with portion choice

@Dieterbe Dieterbe requested a review from rolandgeider May 27, 2024 21:57
@rolandgeider
Copy link
Member

Would a slider be better here? Then it's easier to change the portion size (and it's clearer that we're talking about percentages)

@rolandgeider
Copy link
Member

We could also make the slider move in 10% (or perhaps even 25%?) increments

@Dieterbe
Copy link
Contributor Author

I was thinking something similar. But then I realized I want to be able to enter, say 150% or 200% for those times I need extra kcals. And any such UI would impose an upper limit

@rolandgeider
Copy link
Member

I mean, the slider can also go to 200, with the default being 100 (and you can just log twice, if you need once a bigger amount)

@Dieterbe
Copy link
Contributor Author

logging twice feels like an "unclean" solution, with possible ramifications. but i agree that if we make the need for this uncommon enough, it would be fine. e.g. allowing a portion size upto 150 or 200% maybe.
i was actually thinking a pie chart could be cool too, it could literally be a visual reference that you could match, if you're actually eating a piece of pie or pizza. but that clearly doesn't go above 100%

so okay, i can look into slider widgets. the UI needs some tweaking anyway.
but i suggest to merge this as is, and i'll add some polish later

Base automatically changed from ingredient-form-ux to master May 29, 2024 09:20
@rolandgeider
Copy link
Member

alright

@rolandgeider rolandgeider merged commit 7f4dafd into master May 29, 2024
3 checks passed
@Dieterbe
Copy link
Contributor Author

at a quick glance, we don't currently use such a widget anywhere, so i'll find one on pub.dev, unless you have a tip?

@rolandgeider
Copy link
Member

I think flutter itself has one

@rolandgeider
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants