Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I only managed to get it to work by changing the netstandard to version 2.0 #1

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

BDisp
Copy link
Contributor

@BDisp BDisp commented Sep 19, 2020

No description provided.

@wgross wgross merged commit af1558f into wgross:develop Sep 19, 2020
@wgross
Copy link
Owner

wgross commented Sep 19, 2020

Pulling this in for sure.
I had no good reason to use 2.1 except assuming it might be required by some fancy new C# stuff :-)

@BDisp BDisp deleted the netstandard20 branch September 19, 2020 12:22
@BDisp
Copy link
Contributor Author

BDisp commented Sep 19, 2020

How did you manage to run without getting an error before?

@wgross
Copy link
Owner

wgross commented Sep 19, 2020

Did you run it with PS5? PS5 is compiled with the FullFramework 4.x which supports netstandard 2.0 only. But I'm using PS7 which uses one of the newer versions of the core framework. No problem there with netstandard2.1.

But excluding PS5 from loading the module wasn't intended. It is definitely better to use netstandard2 as long it is possible.

@BDisp
Copy link
Contributor Author

BDisp commented Sep 19, 2020

I really use the PS5.

Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      19041  1

I prefer use the latest stable version applications to not wast time on experimental previews versions that changing a lot until the final version. That why I didn't start working with the NET5 yet :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants