Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the instruction for the bbox statistics #3

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

jiayuasu
Copy link

@wgtmac I had a meeting with Snowflake folks and Iceberg PMCs. After discussion, we decide to put the following instruction for the bbox statistics.

Jira

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@jiayuasu jiayuasu changed the base branch from master to geo August 15, 2024 05:24
@wgtmac wgtmac merged commit 82be6d8 into wgtmac:geo Aug 15, 2024
@wgtmac
Copy link
Owner

wgtmac commented Aug 15, 2024

Merged. Thanks! @jiayuasu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants